# PR Success Playbook for Analytics Engineers
> Learn best practices for dbt pull requests, including naming conventions, folder structures, testing methodologies, and reviewer etiquette for data teams.

Tags: analytics-engineering, dbt, pull-request, code-review, data-modeling, best-practices, sql-testing
## How to Make Reviewers Approve Your PR
* Guide based on Miriam Revilla Alvarez's principles for getting green checks while maintaining code quality.

## The Reviewer's Perspective
* Reviewers feel responsible for production stability.
* Key concerns: Fear of broken prod (40%), Desire to help (30%), Confusion over naming (20%), Hunger (10%).

## Naming Conventions & Folder Structure
* **Standard Prefixes:** `stg_` (Staging), `prep_` (Preparation), `event_` (Curated event data).
* **Ownership:** Folder paths should reflect ownership (e.g., `central_ops_team/staffing/shifts/curated/`). Avoid dumping files in generic folders.

## Documentation & Testing Standards
* **Documentation:** Use precise descriptions instead of "creative writing." Match `{% docs %}` names to field names.
* **Local Testing:** Run `.yml` tests (unique, not_null) and validate business logic (counts, sums) before submitting.
* **The 'To Test' Section:** Must include confirmation of passed tests, queries showing logic validation, and explanation of row count changes.

## PR Etiquette
* Reply to comments explaining fixes; do not resolve comments yourself (the reviewer's job).
* Apply pattern fixes globally, not just on the specific line commented.
* Use `dbt build` commands to allow reviewers to reproduce logic easily.
* Avoid making changes while an active review is in progress.
---
This presentation was created with [Bobr AI](https://bobr.ai) — an AI presentation generator.